Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions): support Map ItemSelector #28771

Merged
merged 9 commits into from
Jan 22, 2024
Merged

feat(stepfunctions): support Map ItemSelector #28771

merged 9 commits into from
Jan 22, 2024

Conversation

abdelnn
Copy link
Contributor

@abdelnn abdelnn commented Jan 19, 2024 •
edited
Loading

Adds support for Map's ItemSelector field and deprecates parameters.

With the release of Distributed Maps, AWS StepFunctions has released a few new fields, and deprecated two old ones for Map states. One of them was Iterator which was replaced with ItemProcessor, the other one is Parameters (replaced by ItemSelector). A similar PR was made to deprecate Iterator (#27913). While they are deprecated, these fields are still supported (PR reflects that)

ItemProcessor and ItemSelector are both fields that are supported in DISTRIBUTED and INLINE mode, hence why they were added to the existing Map construct

Closes #23265

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 19, 2024 01:25
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Jan 19, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 19, 2024 02:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 19, 2024
scanlonp
scanlonp previously requested changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits + you should use assertions in the integ test. Otherwise looks good to me!

packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions/test/integ.map-itemselector.ts Show resolved Hide resolved
packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions/test/integ.map-itemselector.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions/lib/states/map.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions/lib/states/map.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions/lib/states/map.ts
* @see
* https://docs.aws.amazon.com/step-functions/latest/dg/input-output-itemselector.html
*
* @default $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does $ have a significance as a default? Can this docstring be descriptive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ represents the entire state input in Step Functions. Because this is essentially a replacement of parameters, I kept the docstring the same as what it was for parameters.

packages/aws-cdk-lib/aws-stepfunctions/test/map.test.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 20, 2024
@mergify mergify bot dismissed scanlonp’s stale review January 21, 2024 01:15

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 21, 2024
scanlonp
scanlonp previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! Thanks!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed scanlonp’s stale review January 22, 2024 18:16

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 23c2eb8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b226a8c into aws:main Jan 22, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
@abdelnn abdelnn deleted the itemselector branch April 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws_stepfunctions): Depreciated Parameters field in Map
3 participants
@abdelnn @aws-cdk-automation @scanlonp